Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PHP 8.4 runtime support #376

Open
llaville opened this issue Nov 4, 2024 · 6 comments
Open

PHP 8.4 runtime support #376

llaville opened this issue Nov 4, 2024 · 6 comments
Assignees

Comments

@llaville
Copy link
Owner

llaville commented Nov 4, 2024

Summary

Add support to PHP 8.4 runtime

Description

  • Make sure PHP CompatInfo 7.2 runs on the new PHP version and all tests pass.
  • Make sure PHP CompatInfo 7.2 runs on PHP 8.4 without any deprecation notices.
@llaville llaville self-assigned this Nov 4, 2024
@llaville
Copy link
Owner Author

llaville commented Nov 4, 2024

Fix PHP 8.4 deprecation about Implicitly nullable parameter declarations with commit 6349a1b

@llaville
Copy link
Owner Author

llaville commented Nov 4, 2024

One more PHP 8.4 deprecation fixed by commit aaa8950

@llaville
Copy link
Owner Author

llaville commented Nov 4, 2024

Even if deprecations exists (it's for bartlett/sarif-php-sdk package that is not yet compatible with PHP 8.4, but will come soon)

Running unit tests with DB built on tests environment, with following command :

APP_ENV=tests vendor/bin/phpunit --configuration phpunit.xml.dist

Prints these output :

PHPUnit 10.5.38 by Sebastian Bergmann and contributors.

Runtime:       PHP 8.4.0RC3
Configuration: /shared/backups/bartlett/php-compatinfo/phpunit.xml.dist

......D........................................................  63 / 153 ( 41%)
............................................................... 126 / 153 ( 82%)
...........................                                     153 / 153 (100%)

Time: 00:04.342, Memory: 70.00 MB

OK, but there were issues!
Tests: 153, Assertions: 333, Deprecations: 2.

@llaville
Copy link
Owner Author

llaville commented Nov 4, 2024

Requires these configs aaeec85 to run with PHP 8.4

@llaville
Copy link
Owner Author

llaville commented Nov 5, 2024

For Info : my comment related is bartlett/sarif-php-sdk is only for version 1.x; Major version 2.0.x does not suffer this PHP 8.4 incompatibility.

@llaville
Copy link
Owner Author

llaville commented Nov 5, 2024

No deprecations with bartlett/sarif-php-sdk 2.0.1 installed

PHPUnit 10.5.38 by Sebastian Bergmann and contributors.

Runtime:       PHP 8.4.0RC3
Configuration: /shared/backups/bartlett/php-compatinfo/phpunit.xml.dist

...............................................................  63 / 153 ( 41%)
............................................................... 126 / 153 ( 82%)
...........................                                     153 / 153 (100%)

Time: 00:04.434, Memory: 72.00 MB

OK (153 tests, 333 assertions)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant