Skip to content
This repository has been archived by the owner on Sep 26, 2024. It is now read-only.

include player pets into damage done aggregates where necessary #31

Open
ljosberinn opened this issue Jun 13, 2021 · 1 comment
Open

Comments

@ljosberinn
Copy link
Owner

ljosberinn commented Jun 13, 2021

e.g. getDamageDoneToManifestationOfPrideEvents groups units such as treants, frothing postule, greater earth elemental as separate player. to include their damage done, we'd have to link them to the player.

if we're planning to show damage aggregates per class per pride or something, this results in mildly invalid numbers and - worse - redundant data in the db. getDamageDoneToManifestationOfPrideEvents is a non issue however since the events arent currently stored, but immediately used.

@ljosberinn
Copy link
Owner Author

since Prideful season is basically over, above is a bad example. However its notable when e.g. hunters kill Explosive Orbs with Kill Command or the pet uses Claw - these kills should be attributed to the pet owner, right now they get lost.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant