Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LiveView Native Clients: template comments caused stack trace #95

Open
bcardarella opened this issue Apr 18, 2024 · 1 comment
Open
Assignees

Comments

@bcardarella
Copy link

The following:

<!-- ignore this

<!-- ignore this too -->

While this has two opening comment tags the 2nd one should be ignored as it is technically commented out. The first open comment tag should comment all the way until it reaches the first closing comment tag. This current results in a stack trace:

Screenshot 2024-04-18 at 12 01 47 PM
@carson-katri
Copy link
Collaborator

carson-katri commented Apr 18, 2024

This should be raised in core, which handles all document parsing.

Also, nested comments are not valid in HTML. Should we be allowing that anyways?

@bcardarella bcardarella transferred this issue from liveview-native/liveview-client-swiftui Apr 19, 2024
@AZholtkevych AZholtkevych changed the title template comments caused stack trace LiveView Native Clients: template comments caused stack trace Apr 21, 2024
@simlay simlay self-assigned this Apr 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Todo
Development

No branches or pull requests

3 participants