Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

A scrollbar may useless when warp="char" warp="word" #40

Closed
Tracked by #32
littlewhitecloud opened this issue Jun 20, 2023 · 8 comments · Fixed by #32
Closed
Tracked by #32

A scrollbar may useless when warp="char" warp="word" #40

littlewhitecloud opened this issue Jun 20, 2023 · 8 comments · Fixed by #32
Assignees
@littlewhitecloud
Labels
bug Something isn't working invalid This doesn't seem right

Comments

@littlewhitecloud
Copy link
Owner

image
@littlewhitecloud littlewhitecloud added bug Something isn't working invalid This doesn't seem right labels Jun 20, 2023
@Moosems
Copy link
Collaborator

Moosems commented Jun 20, 2023

On the PR?

@littlewhitecloud
Copy link
Owner Author

On the PR?

yes

@Moosems
Copy link
Collaborator

Moosems commented Jun 20, 2023

@littlewhitecloud I'm going to make a to-do list of all the stuff to complete in the PR and then make a separate one in my style to accomplish these. Would you make a list of things you'd like me to do?

@littlewhitecloud
Copy link
Owner Author

You can choose some issues that you’d like to fix~ But issues in #32 need to fix, maybe you can see the fix list in the pr.

@littlewhitecloud
Copy link
Owner Author

littlewhitecloud commented Jun 22, 2023 •
edited
Loading

#22 and #16 both break still and #19 has issues.

Can you open a issues to describe the bug? @Moosems

@Moosems
Copy link
Collaborator

Moosems commented Jun 22, 2023

I can explain 19 better but the other two haven't changed at all. Communicate() is actually just to allow input.

@littlewhitecloud
Copy link
Owner Author

I can explain 19 better but the other two haven't changed at all. Communicate() is actually just to allow input.

So can you open an issues to explain 19?

@Moosems
Copy link
Collaborator

Moosems commented Jun 22, 2023

I'll just expand in the current issue.

@littlewhitecloud littlewhitecloud mentioned this issue Jun 22, 2023
Merged
12 tasks
littlewhitecloud added a commit that referenced this issue Jun 22, 2023
@littlewhitecloud
fix #40
877d7c9
@littlewhitecloud littlewhitecloud changed the title A scrollbar may useless when warp="char" A scrollbar may useless when warp="char" warp="word" Jun 22, 2023
@littlewhitecloud littlewhitecloud self-assigned this Jun 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@littlewhitecloud littlewhitecloud

Labels
bug Something isn't working invalid This doesn't seem right
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

A bunch of fix and improvements littlewhitecloud/TkTerminal
2 participants
@littlewhitecloud @Moosems