Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

suite.lisp - list-all-suites is ill-defined #101

Open
homedirectory opened this issue Oct 11, 2023 · 1 comment
Open

suite.lisp - list-all-suites is ill-defined #101

homedirectory opened this issue Oct 11, 2023 · 1 comment

Comments

@homedirectory
Copy link

homedirectory commented Oct 11, 2023

The following function is defined in src/suite.lisp:

(defun list-all-suites ()
  "Returns an unordered LIST of all suites."
  (hash-table-values *suite*))

The problem with it is that variable *suite* is not used to store a hash table of all suites, but the current test suite object.
Fortunately, this function is not used anywhere at the moment, and the corresponding symbol is not even exported.

Perhaps, *toplevel-suites* was intented to be used?

@homedirectory
Copy link
Author

Aha! I found #4, and it seems that variable *suites* had been introduced previously, and used in list-all-suites. However, the associated commit no longer belongs to any existing branch's history, so I guess it was removed later.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant