Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CS-BOLD-018 Informational 7.15: Small Redemptions Do Not Increase Base Rate #491

Open
bingen opened this issue Oct 9, 2024 · 1 comment
Assignees
Labels
ChainSecurity wontfix This will not be worked on

Comments

@bingen
Copy link
Collaborator

bingen commented Oct 9, 2024

The function CollateralRegistry._getUpdatedBaseRateFromRedemption calculates the base rate from the share of bold tokens that are redeemed.

// get the fraction of total supply that was redeemed
uint256 redeemedBoldFraction = _redeemAmount * DECIMAL_PRECISION / _totalBoldSupply;

As the redeemedBoldFraction is rounded down, splitting a redemption into multiple smaller ones can reduce the fee paid. The most extreme case are redemptions with redeemAmount < totalBoldSupply / 1e18, which will have their fraction rounded to zero, meaning they will not increase the base rate at all. However, multiple redemptions will incur higher gas costs.

@bingen bingen self-assigned this Oct 22, 2024
@bingen bingen added the wontfix This will not be worked on label Oct 22, 2024
@bingen
Copy link
Collaborator Author

bingen commented Oct 22, 2024

For “the most extreme case”, assuming a total supply of 10B (1e10 * 1e18), the redeem amount would be 1e10 wei, i.e. 1e-8 BOLD. It doesn’t make sense to redeem such amount, as the amount paid in gas would be much higher.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ChainSecurity wontfix This will not be worked on
Projects
None yet
Development

No branches or pull requests

1 participant