New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Gas / Packing Notes #33

Open

GalloDaSballo opened this issue Oct 15, 2024 · 0 comments

Collaborator

GalloDaSballo commented Oct 15, 2024

Bold balance can be packed by using the remaining slot

2**136 - 1 / 1e18 is 8e40
Meaning we can represent 8e+31 billion BOLD, which leave ample room to prevent overflows

V2-gov/src/interfaces/IGovernance.sol

Lines 131 to 134 in 9109d98

    
           struct GlobalState { 
        
               uint88 countedVoteLQTY; // Total LQTY that is included in vote counting 
        
               uint32 countedVoteLQTYAverageTimestamp; // Average timestamp: derived initiativeAllocation.averageTimestamp 
        
           }

    struct GlobalState {
        uint88 countedVoteLQTY; // Total LQTY that is included in vote counting
        uint32 countedVoteLQTYAverageTimestamp; // Average timestamp: derived initiativeAllocation.averageTimestamp
    } /// TODO: Bold balance? Prob cheaper

The text was updated successfully, but these errors were encountered:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment