-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Front heat pump #21
base: master
Are you sure you want to change the base?
Front heat pump #21
Conversation
Some units (primarily Vanleigh RVs) may not have a front Heat Pump or it may be moved to a new location in the coach
How does one select what layout they have? FYI I don't own a Tiffin (or a CoachProxy) any more so I'm reviewing/approving these based purely on the code -- I don't have a way to see the changes and test them myself. |
This would be adjusted via the normal settings screen via a Toggle, just as the Mid and Rear HP options are set |
Ah, I see it now in the |
I can do that, is it as simple as duplicating to the _base or is there differences between the two? I wasn't 100% sure on that :) |
It should be really close but I’m not sure if it’s 100% identical. It’s been a really long time since I’ve messed with it! If the surrounding json looks identical, then I guess we can assume the whole thing is identical :-)
… On Jul 6, 2021, at 8:55 PM, ODSMarcus ***@***.***> wrote:
I can do that, is it as simple as duplicating to the _base or is there differences between the two? I wasn't 100% sure on that :)
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub, or unsubscribe.
|
Some units (primarily Vanleigh RVs) may not have a front Heat Pump or it may be moved to a new location in the coach. This allows for this functionality
Resolves #26