Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Front heat pump #21

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Conversation

ODSMarcus
Copy link
Contributor

@ODSMarcus ODSMarcus commented Jul 6, 2021

Some units (primarily Vanleigh RVs) may not have a front Heat Pump or it may be moved to a new location in the coach. This allows for this functionality

Resolves #26

@ODSMarcus
Copy link
Contributor Author

In my specific example, I moved the single HP unit from the front, to the middle, so toggling this works great and the layout follows suit.

image

Some units (primarily Vanleigh RVs) may not have a front Heat Pump or it may be moved to a new location in the coach
@greendog99
Copy link
Collaborator

How does one select what layout they have? FYI I don't own a Tiffin (or a CoachProxy) any more so I'm reviewing/approving these based purely on the code -- I don't have a way to see the changes and test them myself.

@ODSMarcus
Copy link
Contributor Author

This would be adjusted via the normal settings screen via a Toggle, just as the Mid and Rear HP options are set

@greendog99
Copy link
Collaborator

Ah, I see it now in the flows_coachproxy_template.json. If you're up for it, can you also also make those changes in the flows_coachproxy_base.json? That's the initial "first setup" config people see on first boot and usually use to configure the RV.

@ODSMarcus
Copy link
Contributor Author

I can do that, is it as simple as duplicating to the _base or is there differences between the two? I wasn't 100% sure on that :)

@greendog99
Copy link
Collaborator

greendog99 commented Jul 7, 2021 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Allow the toggling of the front heat pump unit
2 participants