Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Create CLinkAddress concept #101

Closed
FreePhoenix888 opened this issue Mar 6, 2022 · 6 comments
Closed

Create CLinkAddress concept #101

FreePhoenix888 opened this issue Mar 6, 2022 · 6 comments
Labels
C++

Comments

@FreePhoenix888
Copy link
Member

FreePhoenix888 commented Mar 6, 2022 •
edited
Loading

CLinkAddress must check that argument is integral and unsigned
@uselessgoddess
Copy link
Member

uselessgoddess commented Mar 8, 2022 •
edited
Loading

No no. Create CLinkType concept because LinkType = integral + unsigned

@FreePhoenix888 FreePhoenix888 changed the title Add std::integral to all TLinkAddress template parameters Create CLinkAddress concept Mar 9, 2022
@FreePhoenix888 FreePhoenix888 transferred this issue from linksplatform/Data.Doublets Mar 9, 2022
@FreePhoenix888
Copy link
Member Author

FreePhoenix888 commented Mar 11, 2022 •
edited
Loading

@uselessgoddess , what do you think about std::three_way_comparable? I think it must be constrained with std::three_way_comparable too

@uselessgoddess
Copy link
Member

uselessgoddess commented Mar 11, 2022 •
edited
Loading

No. They require operator+, operator-, operator*, ....

@uselessgoddess
Copy link
Member

Use like this style:

template <typename Self>
concept LinkType = std::is_unsigned_v<Self>;

@uselessgoddess
Copy link
Member

And move to Numbers

@FreePhoenix888
Copy link
Member Author

Closed in #113

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
C++
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@FreePhoenix888 @uselessgoddess