-
Notifications
You must be signed in to change notification settings - Fork 64
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
autosave not persistant #234
Comments
is this project still alive? I can probably help you debug the problem, I am a developer (got a 50+ million download app). |
don't ask to help. Just help )))
I'm just a user. But I see @ligi appearing from time to time and pulling
some PRs.
|
yea - also need to cut a new release soon |
awesome! :-)))
|
just had a quick dig, I think it might be that you only have onpause, and android can skip onpause in certain cases? |
Lol. Oh I remember being your level of optimistic about android, that passed about 5 years ago... Read the android docs and you will quickly discover that it's all bs, they have fat warnings everywhere saying that they may not happen. The android life cycle is a great idea, but they didn't implement it probably. Now it's garbage. Basically I have seen most parts skipped, or called twice, or called out of order (when there is more than one activity) 🤦 There are different ways to deal with this, mine was to not trust all the life cycle calls, and feed them into my own generic handler of state, then that keeps track of It's own state and calls my own start or stop functions. This then debounces and allows android to forget to call things. At the very minimum you need to combine onPause and onStop (and maybe onSaveInstanceState() ) to get anything reliable. |
The worst of it is: onPause() may be called unexpectedly if the activity is partially obscured by a system dialog or if the system needs to reclaim resources. onResume() may be called unexpectedly if the activity was partially obscured by a system dialog or if the system needed to reclaim resources. onSaveInstanceState() may not be called if the activity is destroyed unexpectedly, such as during a low-memory situation or a process death. onStop() may be called unexpectedly if the system needs to reclaim resources, or if the activity is partially obscured by a system dialog. |
can you point me to where in the docs it states onPause might not be called? |
I am sorry. I was having a bad day and you were looking at the finger pointing rather than what it was pointing at. Maybe just call it a feature not a bug? when you put your phone down it's non-deterministic if you still have your game when you go back, gives you a little gambling kick... also if you are losing the game, then it's like "oh shit, it cleared itself, oh well, shall we start again?" |
Thanks - no I want to fix it - guess I just do the saving after each move then - I think this should solve the problem. |
that is an easy and robust solution. Other ideas would be:
|
Hi everyone, I'm still here, an apology for closing this project. Stop, I'll restart it. If it's still not there, let me know or if you can restart it, go ahead. On the other hand, I thank everyone for their support. |
1 similar comment
Hi everyone, I'm still here, an apology for closing this project. Stop, I'll restart it. If it's still not there, let me know or if you can restart it, go ahead. On the other hand, I thank everyone for their support. |
When the app is closed properly, game progress is lost. That seems like a serious problem.
The text was updated successfully, but these errors were encountered: