Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update language mappings, following update in lila #1318

Open
superuser-does opened this issue Dec 28, 2024 · 2 comments
Open

Update language mappings, following update in lila #1318

superuser-does opened this issue Dec 28, 2024 · 2 comments
Assignees
Labels
cat: l10n Internationalisation and localisation
Milestone

Comments

@superuser-does
Copy link

superuser-does commented Dec 28, 2024

Hello, this is an informative request to advise some language mappings (language-LOCALE.xml files used by Lila) have had their codes updated. See my PR lichess-org/lila#16671 for full details.

Unfortunately, I'm not familiar with how Lichess Mobile pulls translations, beyond the fact the same updates should probably be made in /lib/src/utils/l10n.dart.

If you do update this file, please note also two more commits you may want to sync with:

  1. De-list languages at 3% or lower completion lila#16670 - where 6 languages were delisted from public view.
  2. Asturian was also enabled per lichess-org/lila@fba1016.
@superuser-does superuser-does changed the title Update language mappings within mobile app Update language mappings, following update in lila Dec 29, 2024
@veloce veloce self-assigned this Jan 20, 2025
@veloce
Copy link
Contributor

veloce commented Jan 20, 2025

Ok I will update the mobile side according to your PR. Once it is done I will request a review from you if you don't mind.

@veloce veloce added this to the Public beta milestone Jan 20, 2025
@veloce veloce added the cat: l10n Internationalisation and localisation label Jan 20, 2025
@superuser-does
Copy link
Author

superuser-does commented Jan 20, 2025

Thanks, happy to review.

There have been 3 more keys changed since the above post, c.f. lichess-org/lila#16731. For this, you will also want to remove any "first letter" styling from the results table containing inaccuracies etc, as it's now held in the string itself.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cat: l10n Internationalisation and localisation
Projects
None yet
Development

No branches or pull requests

2 participants