You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Do you think if it would be better to rename the second parameter width to length in *thumbnail related methods?
For me, at the first glance, the name width in documents/code appears like the standard length in x axis strictly. And it misleads when the methods take higher side in consideration and create a 100x200px thumbnail for 400x800px vertical image when width = 200 is specified (with width = 200, it seems as a thumbnail with 200px length in x axis).
Thank you
The text was updated successfully, but these errors were encountered:
Hi,
Do you think if it would be better to rename the second parameter
width
tolength
in*thumbnail
related methods?For me, at the first glance, the name
width
in documents/code appears like the standard length in x axis strictly. And it misleads when the methods take higher side in consideration and create a 100x200px thumbnail for 400x800px vertical image whenwidth = 200
is specified (withwidth = 200
, it seems as a thumbnail with 200px length in x axis).Thank you
The text was updated successfully, but these errors were encountered: