Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature Request] Renaming Second Parameter from width to length in thumbnail operations #212

Open
AmitSonkhiya opened this issue Jul 20, 2023 · 1 comment

Comments

@AmitSonkhiya
Copy link

Hi,

Do you think if it would be better to rename the second parameter width to length in *thumbnail related methods?
For me, at the first glance, the name width in documents/code appears like the standard length in x axis strictly. And it misleads when the methods take higher side in consideration and create a 100x200px thumbnail for 400x800px vertical image when width = 200 is specified (with width = 200, it seems as a thumbnail with 200px length in x axis).

Thank you

@jcupitt
Copy link
Member

jcupitt commented Jul 20, 2023

We can't rename parameters in libvips without breaking API, so we can't make this change. The docs explain what the param means.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants