Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Crash on setup: "Failed building wheel for typed-ast" #12

Open
tburrows13 opened this issue Oct 8, 2020 · 6 comments · May be fixed by #13
Open

Crash on setup: "Failed building wheel for typed-ast" #12

tburrows13 opened this issue Oct 8, 2020 · 6 comments · May be fixed by #13

Comments

@tburrows13
Copy link

Hello,

Starting last week, all of our black GitHub actions started failing during setup, for example: https://github.com/Zulko/moviepy/pull/1334/checks?check_run_id=1220896230

I wonder if the default Python version install in the docker file has changed - FROM python:3 - maybe it went to Python 3.9? (python/typed_ast#146 might be relevant).
@tburrows13 tburrows13 mentioned this issue Oct 8, 2020
Merged
@mflaxman mflaxman linked a pull request Oct 9, 2020 that will close this issue
Open
@mflaxman
Copy link

mflaxman commented Oct 9, 2020

For others, I've submitted a PR to fix this here:
#13

In the meantime, you can see my workaround here:
https://github.com/cryptoadvance/specter-desktop/pull/497/files

@tburrows13
Copy link
Author

Alternatively I found that the actual Black repo psf/black has a GitHub action (even though it is not listed in the GitHub marketplace): https://github.com/Zulko/moviepy/pull/1337/files. It doesn't allow adding arguments to the black call though.

@mflaxman
Copy link

mflaxman commented Oct 9, 2020

Ya, not having arguments wasn't an option for my use-case :(

rdmolony added a commit to codema-dev/drem that referenced this issue Oct 12, 2020
@rdmolony
Switch black action to official
53a2bb7 
lgeiger action failed. Found at lgeiger/black-action#12
codecakes added a commit to Xcov19/covidX that referenced this issue Oct 13, 2020
@codecakes
MYC-90 #fix Fixes lgeiger/black-action#12 #comment using psf/black in…
7a10d61 
…stead
Gowee added a commit to Gowee/telegram-user-tracker that referenced this issue Oct 14, 2020
@Gowee
Fix CI black by switching to the action by psf
ad0206f 
Ref:
lgeiger/black-action#12
https://github.com/Zulko/moviepy/pull/1337/files
@Gowee
Copy link

Gowee commented Oct 14, 2020

Let me try to make the problem clear:

black relies on typed-ast which does not have the .whl ready for Python 3.9, resulting in the need of gcc (and hence failures).

But the official black action by psf now appears to work well on Python 3.9 (see psf/black#1747 and https://github.com/Zulko/moviepy/pull/1337/files given by @tburrows13 ). How could that be done now that its Dockerfile is almost identical to this project's? I am wondering where the magic happens?

@asaf-kali asaf-kali mentioned this issue Oct 14, 2020
Open
@tburrows13
Copy link
Author

@mflaxman psf/black has just added support for custom arguments in psf/black#1755

@mflaxman mflaxman mentioned this issue Oct 18, 2020
Merged
@mflaxman
Copy link

Thank you @tburrows13! I submitted a PR to this open-source project to use it:
cryptoadvance/specter-desktop#529

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

specify python version number mflaxman/black-action
3 participants
@mflaxman @Gowee @tburrows13