Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Workflows: Improve tpm part of test.yml name #930

Open
uncleDecart opened this issue Nov 29, 2023 · 5 comments
Open

Workflows: Improve tpm part of test.yml name #930

uncleDecart opened this issue Nov 29, 2023 · 5 comments
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@uncleDecart
Copy link
Member

What

Currently, jobs in test.yml are running following matrix:

  smoke:
    continue-on-error: true
    strategy:
      matrix:
        file_system: ['ext4', 'zfs']
        tpm: [true, false]

Which generates following name:
Smoke tests (ext4, false)
We want it to be something more meaningful like :
Smoke tests (ext4, no-tpm)

How can we do that?

We can change tpm from boolean parameter to string and compare it to string throughout the test.yml.

Alternatively, if there's a way to change job names to

  smoke:
    continue-on-error: true
    strategy:
      matrix:
        file_system: ['ext4', 'zfs']
        tpm: [true, false]
    name: "Smoke tests ${{ matrix.file_system }} tpm-enabled : ${{ matrix.tpm }}

I prefer the latter, because it's less work and boolean comparison remains

@uncleDecart uncleDecart added enhancement New feature or request good first issue Good for newcomers labels Nov 29, 2023
@uncleDecart
Copy link
Member Author

@milan-zededa what are your thoughts on this?

@milan-zededa
Copy link
Contributor

What would the artifact name be like in the second case?

@uncleDecart
Copy link
Member Author

What would the artifact name be like in the second case?

@milan-zededa "Smoke tests ext4 tpm-enabled : true"

@milan-zededa
Copy link
Contributor

I would prefer the first option for the sake of better readability.

@uncleDecart
Copy link
Member Author

Well, at least I tried 🥲

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

2 participants