Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

undefined index on $options['clarkson_event_skip_date'] #7

Open
jmslbam opened this issue Jul 12, 2017 · 3 comments
Open

undefined index on $options['clarkson_event_skip_date'] #7

jmslbam opened this issue Jul 12, 2017 · 3 comments
Labels

Comments

@jmslbam
Copy link
Contributor

jmslbam commented Jul 12, 2017

$args['meta_query'][] = $this->getEndDateQuery($options['clarkson_event_skip_date']);

Needs a check on it.

$options['clarkson_event_skip_date'] = ( isset( $options['clarkson_event_skip_date'] ) ) ? $options['clarkson_event_skip_date'] : true;

@jmslbam jmslbam added the bug label Jul 12, 2017
@NielsdeBlaauw
Copy link
Member

I think it should default to false, as the default call should not retrieve events in the past.

So maybe:

$options['clarkson_event_skip_date'] = ( isset( $options['clarkson_event_skip_date'] ) && $options['clarkson_event_skip_date'] );

?

@NielsdeBlaauw
Copy link
Member

I see the clarkson_event_skip_date is currently implemented exactly opposite of skipping the date, which feels strange to me.

@jmslbam
Copy link
Contributor Author

jmslbam commented Jul 13, 2017 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Development

No branches or pull requests

2 participants