Properly handle if should ZIP and work-folder creation and file naming #272
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shouldZipFile() was only checking how many pages the source had, instead of how many pages are actually set to be downloaded.
Some English writing improvements
Fixes the "Don't create work folder" > "When there is only one image" setting logic. Also fixes the name combining for it.
Invertex
changed the title
|
I don't know how to merge single commit from these three, so I picked ba9c8bc manully. For work-folder creation, I'll add a option to handle it differently. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
shouldZipFile()was only checking how many pages the source had, instead of how many pages are actually set to be downloaded.Fixes #261
Also made the same changes for the "Don't create work folder" settings.
Fixes: #270