-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Missing data for mixed.gen.Burridge_Schneider_2017 #65
Comments
I put in the parent terms for stuff that's missing in the TO like "Root Tip Abundance" (RTA). Unless there's an ontology term for the Rochester Transit Authority. |
Point 1 (missing Burridge-Schneider markers) is still unresolved. |
@cann0010 is there a source for the missing Cowpea1MSelectedSNPs marker maps to vigun.IT97K-499-35.gnm1? Otherwise we'll just close this, we can't create data that don't exist. Here's what's in the qtlmrk file:
|
Some sleuthing: It's not the IT97K-499-35.gnm1.div.Huynh_Ehlers_2018 diversity set, which has only 32k markers. ... which traces back to Muchero et al, 2009 YES: Supplement for that Muchero et al paper (tsp file attached; derived from manuscript supplement 0905886106_SD1.xls) |
thanks @cann0010! just glancing at the file it looks like at least some of the qtlmrk markers correspond to SNPs in the Cowpea1MSelectedSNPs, using the column 1 (SNP) as the match, e.g. 13772_1075 from the list above -> 1_0749 which is in the 1M set. Think it's legit to substitute the SNP ids for the "marker" ids in the qtlmrk file? Seems better to me to do so, but let me know if you agree with this change and I can make it so. |
What matters is that the identifier in the qtlmarker file is the Name attribute of the marker in the GFF. That's how they're merged. Otherwise it'll be stranded markers with no genomic location. |
(There are likely marker GFFs that will show up as issues because they don't have full-yuck ID attributes and short-name Name attributes, although I'll typically fix those myself.) |
only 17 out of the 22 SNPs can be found in the 1M set; so we may have to get genomic locations for the others by mapping the sequences. Since they are not all in the 1M set, perhaps we should just treat them as their own little marker collection? |
Fine with me, be sure to update README.genotyping_platform with your new name if/when you do. |
OK, probably won't get to it for a while, but will re-assign to myself (though others are welcome to wrest it back) |
ping @adf-ncgr |
But also, @adf-ncgr you're really good at hijacking issues, which is not an instant messaging app. So please if you have a new issue like "what to do with marker sequences" create a new one rather than hijacking this one. Much appreciated. I'll do so with these posts. legumeinfo/datastore-specifications#24 |
thanks, you're right. |
I think this got sorted out over time. Or we'll create a fresh issue but I've got VignaMine loaded and running. |
For cowpea QTL data in v2/Vigna/unguiculata/genetic/mixed.gen.Burridge_Schneider_2017/
Markers listed in vigun.mixed.gen.Burridge_Schneider_2017.qtlmrk.tsv.gz are not found in Vigna/unguiculata/markers/IT97K-499-35.gnm1.mrk.Cowpea1MSelectedSNPs/vigun.IT97K-499-35.gnm1.mrk.Cowpea1MSelectedSNPs.gff3.gz
In vigun.mixed.gen.Burridge_Schneider_2017.obo.tsv.gz, some traits have no ontology code.
The text was updated successfully, but these errors were encountered: