Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improving python client docs #2

Open
riibeirogabriel opened this issue Oct 3, 2020 · 18 comments
Open

Improving python client docs #2

riibeirogabriel opened this issue Oct 3, 2020 · 18 comments
Assignees

Comments

@riibeirogabriel
Copy link
Member

@navendu-pottekkat do you can think a way to improve the quality of the docs?

@riibeirogabriel
Copy link
Member Author

I did have think a way, but is too much classes and methods in this package.

@pottekkat
Copy link
Member

I will check it out. We can find some way. I will work on it through the week.

@riibeirogabriel
Copy link
Member Author

thanks! I also will think a way.

@pottekkat
Copy link
Member

@riibeirogabriel Could you possibly comment the example code? And is there any way to split the preprocessing_code other than writing it as preprocessing_code = ```from ...

We can also change the '_' in the imports to '-'

@riibeirogabriel
Copy link
Member Author

riibeirogabriel commented Oct 3, 2020

The preprocessing_code is sended as string in API, and the model builder microservice interpret this string as python 3 code, this code is the right way to work, but maybe we can write a session with the preprocessing_code uncommented, to highlight the python sintax and make the comments, what do you think? and ok, we can change from "_" to "-".

@pottekkat
Copy link
Member

The preprocessing_code is sended as string in API, and the model builder microservice interpret this string as python 3 code, this code is the right way to work, but maybe we can write a session with the preprocessing_code uncommented, to highlight the python sintax and make the comments, what you think? and ok, we can change from "_" to "-".

Oh I did not know it worked that way. Then you should do what you think the best. Then you can comment and change the underscores.

I will take a look at the docs repo and the landing page tomorrow. You can also work on getting a domain address if you are interested. It is late here and that is one of the problems when we are working from 2 opposite ends of the world!

@riibeirogabriel
Copy link
Member Author

Okay, it will see this and make something, thanks!

@riibeirogabriel
Copy link
Member Author

@navendu-pottekkat We can create another repo to serve the landing page in a github.io domain? It is a temp solution, till i provide a domain in next releases of learingOrchestra,and i don't have knowledge in front end to build a landing page.

@pottekkat
Copy link
Member

@riibeirogabriel Yes, that is what I was planning to do. We will create a landing page in a new repo. And later we can add the domain. And we can keep the docs in a subdomain like docs.website.com

It would be best if you get the domain ASAP and we can start the promotion. Lot of folks will contribute for hacktoberfest

@riibeirogabriel
Copy link
Member Author

@navendu-pottekkat alright, I will provide the domain in this week!

@riibeirogabriel
Copy link
Member Author

riibeirogabriel commented Oct 4, 2020

I have installed the learning-orhcestra-client and success! but to run the python interpreter on .py file, is throwed a exception in "import learning-orchestra-client" as invalid sintax, the PEP8 recommends use underscores in variables, maybe it can be relationed.
image

@riibeirogabriel
Copy link
Member Author

@navendu-pottekkat and thanks for all help for this project, you did make the learningOrchestra more professional and friendly to users!

@pottekkat
Copy link
Member

Then maybe we should change that in the README

@pottekkat
Copy link
Member

Actually in the readme it is learning_orchestra_client

@riibeirogabriel
Copy link
Member Author

Okay

@pottekkat
Copy link
Member

Okay

I will make a PR by EOD with the landing page website

@riibeirogabriel
Copy link
Member Author

riibeirogabriel commented Oct 8, 2020

@navendu-pottekkat Maybe we can rename this repo from learningOrchestra-python-client to python-client, what do you think?

@pottekkat
Copy link
Member

pottekkat commented Oct 8, 2020 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants