-
Notifications
You must be signed in to change notification settings - Fork 48
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Start lean server using lake serve
#85
Comments
From Gabriel: On a high level, the biggest question is how the fallback should work. That is, when do we try lean --server after lake serve fails? Do we just call lake serve if there is a lakefile.lean present? There's also a lot of tiny annoyances left. The extension has a configuration for the lean executable. Do we add one for lake as well? There is some version selection code by Chris which also makes it a bit harder to change replace lean --server by lake serve. From Sebastian: Can we replace this with a setting for the toolchain root path (keeping bin/lean as the sanity check)? I'd like to avoid tying this to elan if not necessary. |
I don't think it makes sense to fall back to |
Yep, Mac showed me the "--" command line trick, so I already changed the code to use "lake serve -- filename" and "lake +version serve -- filename". I updated the PR description to match. |
This PR is now merged |
Related to #61.
The text was updated successfully, but these errors were encountered: