Slow code on critical path of CLI startup

[bartekpacia]

This code:

patrol/packages/patrol_cli/lib/src/analytics/analytics.dart

Lines 37 to 46 in 06a5041

	class Analytics {
	Analytics({
	required String measurementId,
	required String apiSecret,
	required FileSystem fs,
	required Platform platform,
	http.Client? httpClient,
	FlutterVersionGetter getFlutterVersion = _getFlutterVersion,
	required bool isCI,
	}) : _fs = fs,

is executed on the critical path of Patrol CLI startup. The problem is that it calls flutter --version:

patrol/packages/patrol_cli/lib/src/analytics/analytics.dart

Lines 186 to 191 in 06a5041

	FlutterVersion _getFlutterVersion() {
	final result = io.Process.runSync(
	'flutter',
	['--no-version-check', '--version', '--machine'],
	runInShell: true,
	);

and it's really slow (~2-3 seconds on my M1 MBA).

We should find a way to not block on it, because it's only needed for analytics. This is especially annoying when trying to use tab completion in shell – it makes completion way to slow, practically unusable.

[piotruela]

@bartekpacia I tried to reproduce this problem but it's fast on my machine. I measured execution time of flutter --version and it's around 100ms. No matter if it's called by patrol_cli or typed by me in the console

[bartekpacia]

Hmm, I must've had weaker network connection then. Still, this is something to be fixed, but maybe not with P1 but P2.

You should be able to reproduce this by adding some artificial timeout to _getFlutterVersion.

[bartekpacia]

The problem I had in mind here is actually the update check being performed synchronously, see #2512