Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix getProperty to properly handle false values #238

Open
AntoineGautier opened this issue Aug 6, 2024 · 0 comments
Open

Fix getProperty to properly handle false values #238

AntoineGautier opened this issue Aug 6, 2024 · 0 comments

Comments

@AntoineGautier
Copy link
Contributor

The function getProperty defined at https://github.com/lbl-srg/modelica-json/blob/master/lib/jsonquery.js#L8-L10 returns null if a property has a false value.

getProperty(['foo', 'foz'], { foo: { foz: false }}); // returns null

This ticket is to use the nullish coalescing operator as below so that the function returns false in this case.

const getProperty = (p, o) => p.reduce((xs, x) => xs?.[x] ?? null, o)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant