Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

recurring issue for small things #30

Open
10 of 13 tasks
laurgao opened this issue May 7, 2024 · 0 comments
Open
10 of 13 tasks

recurring issue for small things #30

laurgao opened this issue May 7, 2024 · 0 comments

Comments

@laurgao
Copy link
Owner

laurgao commented May 7, 2024

  • remove unneeded comment in simplify
  • fix this
    image
  • fix this also (integrand = 2*x+3/(x-3)/(x+3)) (n/a was not an issue, first term of sum is not expanded)
    image
  • fix this Prod([-Fraction(4, 5), -1**Fraction(5, 2)*x**Fraction(5,2)])
    image
  • this is because recursive self.is_subtraction = True & keep multiplying by -1 when doing Prod.__repr__. (temporarily patched it so it doesn't fail silently, but idk would need to think of more robust architectural decisions to fix it fr, and i don't rlly see myself encountering this error for now so im just gonna leave it unimplemented.)
    image
  • (-1)^(5/2) gets displayed as -1^(5/2) which changes meaning in some cases
  • sqrt(-x) gets expanded to sqrt(-1)sqrt(x) which is maybe unideal
  • cos(x+2pi) & sin(x+2pi) doesn't get converted to cos(x) or sin(x) for some reason (made an xfailed test)
  • omg this is rlly bad it doesn't display the brackets? also this should accumulate lmfao image
    image. there's 2 things here: (1) is prod should show brackets?? or just multiplying a sum by -1 should do it across all terms -> the 2 non-ln terms will accumulate.
  • (2) is ln(4) - ln(2) should accumulate. at least for simplify.
  • ln(4) + 9/16 - ln(2) gets displayed in this order. pls move all consts to the end.
  • fix this
    image
  • if a term of the solution is constant, rid it?
@laurgao laurgao pinned this issue May 15, 2024
laurgao added a commit that referenced this issue May 31, 2024
laurgao added a commit that referenced this issue May 31, 2024
laurgao added a commit that referenced this issue May 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant