Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

This test document is breaking joplin. Has something to do with the "Fenced code block" section. #11154

Closed
futuremotiondev opened this issue Sep 29, 2024 · 5 comments
Labels
backlog We'll get to it... eventually... bug It's a bug desktop All desktop platforms

Comments

@futuremotiondev
Copy link

Operating system

Windows

Joplin version

3.1.17

Desktop version info

Joplin 3.1.17 (prod, win32)

Client ID: 470c00f76de6488a98fd6a25df21fcda
Sync Version: 3
Profile Version: 47
Keychain Supported: Yes

Revision: 3ea403d

Backup: 1.4.2
Csv Import: 1.0.1
Favorites: 1.3.2
Headings 4 to 6: 1.0.1
Insert Date: 1.0.1
Paste Special: 1.1.2
Table Formatter Plugin: 1.2.1

Current behaviour

  1. Open this test jex document in Joplin: MD Test Document.zip
  2. If Joplin doesn't go completely unresponsive, check the markdown source and look at the <pre> tag directly under the "Fenced" code block H3 heading.
  3. See that Joplin injected a ton of backslashes followed by a final back-tick.
  4. The original markdown source was this: https://gist.github.com/jonschlinkert/5854601#fenced-code-block

Expected behaviour

I expected Joplin to not insert massive amounts of backslashes into the document, even if the markdown was malformed.

I really do not know if what I supplied is sufficient to replicate the issue as I'm not sure when the corruption actually happened. But I suspect some kind of character escaping logic with code blocks isn't working right. It's also possible that an older version of the app broke the document and the bug no longer exists. I felt like reporting the issue anyway would be best as it might lead to some kind of bug fix.

Logs

No response

@futuremotiondev futuremotiondev added the bug It's a bug label Sep 29, 2024
@futuremotiondev
Copy link
Author

... that's not suspicious at all

@laurent22 laurent22 added desktop All desktop platforms high High priority issues labels Sep 29, 2024
Repository owner deleted a comment Dec 12, 2024
@pedr
Copy link
Collaborator

pedr commented Dec 13, 2024

When I imported your .jex file, the editor slowed down, probably because of the number of backslashes, but I can't find a reason or how to reproduce it for now.

I tried to reproduce the bug by:

  • Copying the raw content from the gist to the markdown editor, changing between editors to see if it would make the backslashes appear
  • Copied the HTML content from the gist and pasted on on Rich Text Editor and got this [1], which I think it is what we expected

[1]
image

@pedr
Copy link
Collaborator

pedr commented Dec 16, 2024

@futuremotiondev I tried to reproduce it and couldn't do it. How did you create the note? Can you give me more detailed steps?

@pedr pedr removed their assignment Dec 23, 2024
@pedr pedr added backlog We'll get to it... eventually... and removed high High priority issues labels Dec 23, 2024
@pedr
Copy link
Collaborator

pedr commented Dec 23, 2024

Moving to backlog for now as I could not reproduce, if the author could provide more information on how to reproduce I can work on this again.

@pedr pedr closed this as not planned Won't fix, can't repro, duplicate, stale Dec 23, 2024
@futuremotiondev
Copy link
Author

@futuremotiondev I tried to reproduce it and couldn't do it. How did you create the note? Can you give me more detailed steps?

Yeah, I'm really sorry I can't provide more information. I know that the note initially did not have all of the backslashes, but I have no clue when and how the corruption occurred. I thought it might have had something to do with escape sequence parsing in html designated code blocks but I'm only just speculating.

The bug could have already been fixed as well. Either way I've had no similar problems since, so I don't think it's a big issue. If I run into it again and find an exact way to reproduce it I'll make a new issue about it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backlog We'll get to it... eventually... bug It's a bug desktop All desktop platforms
Projects
None yet
Development

No branches or pull requests

3 participants