Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move to Node.js' assert.js #137

Open
larsgw opened this issue May 3, 2018 · 1 comment
Open

Move to Node.js' assert.js #137

larsgw opened this issue May 3, 2018 · 1 comment
Labels
tests Unit/integration tests, CI, etc.

Comments

@larsgw
Copy link
Owner

larsgw commented May 3, 2018

PRO

  • A dependency less
  • No more issues with 'use strict' (Browser test build #55, 7c475b6)
  • Same functionality
  • Supported by browserify
  • Maintained by the Node.js people themselves (expect.js hasn't been updated since 2015)

CON

  • A system library (but does that really matter?)
  • It takes time to switch (especially since it's assert-style, not expect-style)
@larsgw larsgw added the tests Unit/integration tests, CI, etc. label May 3, 2018
@larsgw
Copy link
Owner Author

larsgw commented Jan 2, 2019

A lot of these are converted while rewriting the tests for the new repository: citation-js/citation-js@57ba9ff#diff-098f6bcd4621d373cade4e832627b4f6. Only the core package tests are still expect.js.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
tests Unit/integration tests, CI, etc.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@larsgw