Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migration Issues: Upgrading from Inertia.js v1 to v2 #107

Closed
jrmybtlr opened this issue Nov 20, 2024 · 4 comments
Closed

Migration Issues: Upgrading from Inertia.js v1 to v2 #107

jrmybtlr opened this issue Nov 20, 2024 · 4 comments
Assignees

Comments

@jrmybtlr
Copy link
Member

jrmybtlr commented Nov 20, 2024

Laravel Precognition Plugin Version

"laravel-precognition-react-inertia": "^0.5.6",

Laravel Version

11.9

Plugin

React w/ Inertia

Description

During the migration from Inertia.js v1 to v2, we're encountering peer dependency conflicts with laravel-precognition-react-inertia which is still expecting Inertia.js v1.

Current Behavior

Error Message

npm warn ERESOLVE overriding peer dependency
npm warn While resolving: n*******h.laravel.com@undefined
npm warn Found: @inertiajs/[email protected]
npm warn node_modules/@inertiajs/react
npm warn   peer @inertiajs/react@"^1.0.0" from [email protected]
npm warn   node_modules/laravel-precognition-react-inertia
npm warn     laravel-precognition-react-inertia@"^0.5.6" from the root project

Steps To Reproduce

  1. Start with a working Inertia.js v1 installation
  2. Run upgrade command:
    npm install @inertiajs/react@next
@timacdonald timacdonald self-assigned this Nov 21, 2024
@onlime
Copy link

onlime commented Nov 22, 2024

Tested the Vue version with Inertia.js v2 @inertiajs/[email protected] by force installing (npm i --force) [email protected] which works perfectly fine. So, please just bump the peer deps. Thanks @timacdonald !

@timacdonald
Copy link
Member

Hey, folks, will be doing some testing across the stacks next week. Can't imagine there is anything breaking.

Will tagged a new version once we confirm all the stacks.

@valh1996
Copy link

valh1996 commented Dec 2, 2024

Hey, folks, will be doing some testing across the stacks next week. Can't imagine there is anything breaking.

Thank you! Do you have any news on this subject please ?

@timacdonald
Copy link
Member

I've opened a PR to add inertia 2.0 support: #108

We can close this PR and follow the PR progress.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants