Contracts missing
#33530
Replies: 1 comment
-
@taylorotwell regarding #33547, should be created additional contract (\Illuminate\Contracts\Routing\Redirector)? |
Beta Was this translation helpful? Give feedback.
0 replies
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
-
Hi!
I'm developing a route localization package(https://github.com/soluzione-software/laravel-localization/).
In order to be transparent for package users, I need to extend(by using $this->app->extend(...)) some basic services(\Illuminate\Routing\Redirector and some others).
Troubles comes where these services are used directly without a contract, see:
framework/src/Illuminate/Routing/Redirector.php
Line 33 in 8d83d7d
Can we consider removing(less preferred choice) Type declaration from constructor or methods and leave them only in php doc or implement some contracts(best choice)?
Thanks!
Beta Was this translation helpful? Give feedback.
All reactions