-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Channel Launch #1
Comments
Website PR was merged here: @antonkomarev @FunfareNico feel free to tag v1 whenever you are ready (then close this issue). Thanks! |
I think we need to fix tests first of all, and @FunfareNico was wanted to add attachments to the package. |
@Funfare why did you released v0.1 such early? What's the rush? I'm not sure this package was ready for it. Code style is not finished. Publishing release as soon as you merging PR without any review and answering questions is not that good. I understand that package was under development for a long time, but it would be better to polish it up for a stable public releases. If you are scary to break application with latest commits to master branch you can always freeze package on exact hash in your application. |
It will be good to switch from TravisCI to GitHub actions workflow. |
You have admin privileges on the repo, so you should be able to set that up. Let me know if you run into any issues. |
@atymic could you add me to https://github.com/orgs/laravel-notification-channels/people list, please? |
The text was updated successfully, but these errors were encountered: