Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update plot_states defaults #21

Merged
merged 2 commits into from
Mar 26, 2024
Merged

Update plot_states defaults #21

merged 2 commits into from
Mar 26, 2024

Conversation

ccoffrin
Copy link
Member

I think be default we want plot_states to show all states, the user can trim it down when they know that is what they want.

@ccoffrin ccoffrin requested a review from zmorrell March 25, 2024 04:56
Copy link

codecov bot commented Mar 25, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.22%. Comparing base (19854d1) to head (175e04b).
Report is 3 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #21      +/-   ##
==========================================
+ Coverage   90.27%   91.22%   +0.95%     
==========================================
  Files           2        4       +2     
  Lines         185      228      +43     
==========================================
+ Hits          167      208      +41     
- Misses         18       20       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@zmorrell zmorrell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does it make more sense to default to using all states, or would it be better to change it to be both num_states = 0 and energy_levels = 1 since the more likely default use case for people would be plotting ground states? That could prevent over-saturation on the x-axis for models larger than 4 qubits while also not providing an annoying limitation that only views low probability high energy states.

src/plot.jl Show resolved Hide resolved
@zmorrell zmorrell merged commit 2a27de6 into main Mar 26, 2024
9 checks passed
@ccoffrin ccoffrin deleted the plot-states-update branch March 26, 2024 15:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants