Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Произвести рефакторинг приложения на iOS #127

Open
4 of 9 tasks
broadwaylamb opened this issue Jul 11, 2016 · 1 comment
Open
4 of 9 tasks

Произвести рефакторинг приложения на iOS #127

broadwaylamb opened this issue Jul 11, 2016 · 1 comment
Assignees
@broadwaylamb
Labels
enhancement iOS
Milestone
future

Comments

@broadwaylamb
Copy link
Member

broadwaylamb commented Jul 11, 2016 •
edited
Loading

На данный момент покрытие кода приложения составляет всего 10% — юнит-тесты писать тяжело из-за того что view controller'ы в MVC выполняют слишком много действий.

Предлагается использовать Clean Architecture в качестве предпочтительной архитектуры проекта. Это позволит разделить обязанности, которые имеет сейчас view controller, на три модуля: непосредственно view controller, interactor (модуль, взаимодействующий с моделью в MVC) и presenter (модуль, представляющий данные в наиболее удобном для отображения view controller'ом виде). В результате должна улучшиться тестируемость и гибкость кода.

Шаблоны для Xcode

Переработанные и протестированные сцены:

  • Password
  • Home
  • ChooseFile
  • KeyType
  • NumberOfKeys
  • ProvideKey
  • LibraryDirectory
  • Library
  • ViewFile
@broadwaylamb broadwaylamb added this to the Summer 1 milestone Jul 11, 2016
@broadwaylamb broadwaylamb self-assigned this Jul 11, 2016
@adavydenko
Copy link
Member

adavydenko commented Jul 11, 2016 •
edited
Loading

Думаю, что это имеет смысл обсудить.
На ретроспективе договорились новую функциональность разрабатывать с учетом Clean Architecture, рефакторинг производить позже.

@adavydenko adavydenko modified the milestones: Summer 1, Summer 2 Jul 11, 2016
broadwaylamb added a commit that referenced this issue Jul 11, 2016
@broadwaylamb
#127: Use Clean Architecture for Password Scene + Unit Tests
82d57ed
broadwaylamb added a commit that referenced this issue Jul 12, 2016
@broadwaylamb
#127: Initiate moving to Clean Architecture for Choose File Scene
133544f
broadwaylamb added a commit that referenced this issue Jul 12, 2016
@broadwaylamb
#127: ChooseFile refactoring (unfinished yet)
982fec2 
Use JSQDataSourcesKit for UICollectionView
broadwaylamb added a commit that referenced this issue Jul 13, 2016
@broadwaylamb
#127: Reorganize ChooseFile scene
5538bfd 
Fix continuous integration
broadwaylamb added a commit that referenced this issue Jul 14, 2016
@broadwaylamb
#127: Rename FileInfoDataSource → PresentedDataSource, make it generic.
78148fc 
Unit tests for PresentedDataSource.
@broadwaylamb broadwaylamb mentioned this issue Jul 14, 2016
Merged
@adavydenko adavydenko modified the milestones: 2016 Summer, Summer 2 Jul 18, 2016
broadwaylamb added a commit that referenced this issue Jul 18, 2016
@broadwaylamb
#127: Use Clean Architecture for KeyType Scene + Unit Tests
99ec1f1
broadwaylamb added a commit that referenced this issue Jul 20, 2016
@broadwaylamb
#127: Use Clean Architecture for NumberOfKeys Scene + Unit Tests
a91d957 
Improve unit tests for KeyType scene
@adavydenko adavydenko modified the milestones: 2016 Summer, future Jul 29, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@broadwaylamb broadwaylamb

Labels
enhancement iOS
Projects
None yet
Milestone
future
Development

No branches or pull requests
2 participants
@adavydenko @broadwaylamb