Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prevent colliding internal cache ids based on adapter #2

Closed
weierophinney opened this issue Dec 31, 2019 · 1 comment
Closed

Prevent colliding internal cache ids based on adapter #2

weierophinney opened this issue Dec 31, 2019 · 1 comment
Labels
Bug Something isn't working Duplicate This issue or pull request already exists Unit Test Needed

Comments

@weierophinney
Copy link
Member

Resolves #41
json_encode($this->getAdapter()) would always return an empty object for \Zend\Paginator\Adapter\DbSelect adapters (i.e. {}). By performing print_r on the adapter we can get the current state which, in the case of DbSelect, includes an sql object containing table name, join details, where clause, etc.
This change will prevent collisions between adapters that do not have any public properties and/or values.


Originally posted by @richard-parnaby-king at zendframework/zend-paginator#42

@froschdesign
Copy link
Member

Duplicate of #3

@froschdesign froschdesign marked this as a duplicate of #3 Jun 18, 2020
@froschdesign froschdesign added the Duplicate This issue or pull request already exists label Jun 18, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something isn't working Duplicate This issue or pull request already exists Unit Test Needed
Projects
None yet
Development

No branches or pull requests

2 participants