Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Verify composer.json constraint changes #118

Open
boesing opened this issue Aug 10, 2022 · 0 comments
Open

Verify composer.json constraint changes #118

boesing opened this issue Aug 10, 2022 · 0 comments
Labels
Enhancement Feature Request RFC Request for Comment; proposal for major new feature or changes.

Comments

@boesing
Copy link
Member

boesing commented Aug 10, 2022

Feature Request

Q A
New Feature yes
RFC yes
BC Break no

Summary

We do have a few components where we actually implement specific interfaces, such as PSR ones.
We had a release for laminas-servicemanager which stated to support psr/container v2 support. That was incorrect, due to several things:

  1. the composer.json did not provide support for ^2.0 of the psr/container package via psr/container-implementation.
  2. the composer.lock did not contain the latest version of psr/container since it got blocked by a 3rd-party library which did not supported psr/container v2 yet (but was only added as a dev-dependency)

At least due to the 2nd issue, all tests were passing and thus the PR got merged.


So what we could try to do is:

  1. use diff to find those packages which were changed
  2. use jq to extract provide packages
  3. compare provide constraint with require constraint

Or maybe something else. I'll keep this here to keep track of my ideas.

@boesing boesing added Enhancement Feature Request RFC Request for Comment; proposal for major new feature or changes. labels Aug 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Enhancement Feature Request RFC Request for Comment; proposal for major new feature or changes.
Projects
None yet
Development

No branches or pull requests

1 participant