Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement Effective Temperature module from ladybug legacy code #33

Open
chriswmackey opened this issue Sep 26, 2019 · 1 comment
Open
Labels
backlog comfort documentation For issues requiring changes to documentation enhancement New feature or request hacktoberfest help wanted Extra attention is needed ladybug

Comments

@chriswmackey
Copy link
Member

As many ladybug legacy users know, @stgeorges did a phenomenal job writing code for calculating effective temperature and apparent temperature in ladybug-leagcy. At this point, it would be great to further clean + document this code and and integrate it into ladybug-comfort such that other developers can easily calculate effective and apparent temperature using the ladybug-comfort package on PyPI and view documentation about the model within the online documentation for this repo.

You can see that I have already done an example of translating one of the models from @stgeorges 's components with the Heat Index (HI) in this library. This was translated over from the heat index function in the thermal indices component and the references in the docstring came from on the wikipedia page for heat index.

I am posting this issue here in the event that someone sees it and decides that they would like to take up the mantle of transferring this code, documenting it, and getting it to conform to PEP8. If anyone has interest, please feel free to post on this issue.

@chriswmackey chriswmackey added enhancement New feature or request help wanted Extra attention is needed documentation For issues requiring changes to documentation ladybug comfort hacktoberfest labels Sep 26, 2019
@chriswmackey
Copy link
Member Author

As an additional note to a question @janeliutw brought up, I think that Effective Temperature should be broken down into two methods:

  1. For effective temperature (ET or TE)
  2. For radiant effective temperature (RET or TRE)

@chriswmackey chriswmackey changed the title Implement Effective Temperature and Apparent Temperature modules from ladybug legacy code Implement Effective Temperature module from ladybug legacy code Oct 30, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backlog comfort documentation For issues requiring changes to documentation enhancement New feature or request hacktoberfest help wanted Extra attention is needed ladybug
Projects
None yet
Development

No branches or pull requests

2 participants