-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Consider implementing dynamic Apertures on the ModifierSet #32
Comments
That's a great point. Making a dynamic material as a standard object will go a long way. I think we should think about it more than just a list of modifiers. |
Agreed. Having a special type of |
Now that I see that a state needs to be an entire object like an |
Now that I have gone through the whole implementation of dynamic objects, I see that there's a major flaw in the idea of a "dynamic modifier" that can be assigned to a ModifierSet. This is that the logic for how different apertures are grouped is not inherent in the dynamic modifier and any default behavior that we could think of (like exporting each aperture geometry with a dynamic modifier into a separate group) is rarely desired. So, if we end up implementing something like this, there will have to be some rules that govern when the dynamic modifier takes effect like:
|
For the PR that I am about to send, I am implementing the ability to assign an array of modifiers to an Aperture to represent different states. However, I am going to keep the Aperture modifiers on the ModifierSet as static now for simplicity.
However, I can see that, at some point, we may want to allow for states in the ModifierSet if someone wants to make a ModifierSet for a building that has electrochormic for all of its windows. It seems like this will probably be a desired feature but I think we should first work it out with states assigned on an Aperture-by-Aperture basis.
The text was updated successfully, but these errors were encountered: