Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update CLI to request VFolders using ID retrieved by name #3466

Closed
HyeockJinKim opened this issue Jan 15, 2025 — with Lablup-Issue-Syncer · 0 comments
Closed

Update CLI to request VFolders using ID retrieved by name #3466

HyeockJinKim opened this issue Jan 15, 2025 — with Lablup-Issue-Syncer · 0 comments
Assignees

Comments

@HyeockJinKim
Copy link
Collaborator

HyeockJinKim commented Jan 15, 2025

Motivation  

[Why is this Story important? Explain the context and reasons for this feature or change.]  

  • The CLI for managing VFolders currently relies on the name value for requests. However, there may be multiple VFolders with the same name, which can cause unexpected behavior or failures.
  • The CLI should retrieve the corresponding id for a given name and proceed with the request using the id. If multiple VFolders exist with the same name, the user should be prompted to choose the appropriate one.  

Required Features

[Clearly describe the features or functionality needed for this Story.]  

  • Update the SDK to retrieve the id when only the name is provided and use the id for subsequent requests.
  • Enhance the API to include additional information in the error response when multiple IDs are found for the same name.

Impact  

[Specify which components or services will be affected by this Story.]  

  • Operations involving name in environments like super admin will fail if multiple VFolders with the same name exist.
    • Users should be able to utilize the additional data in the error response to reattempt the request with the correct id.

Testing Scenarios  

[Outline test cases or scenarios for validating the implementation.]  

  • Test request execution using the name:
    • When no VFolder matches the name.
    • When exactly one VFolder matches the name.
    • When multiple VFolders match the name (verify error message details).
  • Test request execution using the id:
    • Ensure functionality works correctly with valid id.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant