Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ordering policy of resource presets #1633

Open
achimnol opened this issue Oct 19, 2023 · 0 comments
Open

Ordering policy of resource presets #1633

achimnol opened this issue Oct 19, 2023 · 0 comments
Labels
comp:manager Related to Manager component effort:normal Need to understand a few modules / some extent of contextual or historical information. urgency:3 Must be finished within a certain time frame.
Milestone

Comments

@achimnol
Copy link
Member

achimnol commented Oct 19, 2023

Currently, resource presets are only alphabetically ordered (when requesting a specific set of resource presets by names):

.order_by(resource_presets.c.name)

or unordered (when listing all resource presets at once):

query = sa.select([resource_presets]).select_from(resource_presets)

Let's add an option to explicitly order them:

  • LEXICOGRAPHIC_ASC: alphabetically ordered
  • LEXICOGRAPHIC_DESC: alphabetically reverse-ordered (new)
  • RESOURCE_SIZE_ASC: smaller resource preset first (new)
  • RESOURCE_SIZE_DESC: larger resource preset first (new)

To define the relative size of resource presets, we should have a resource slot precedence to make them comparable with each other. Fortunately, we already apply a similar precedence-based ordering when calculating the optimal hardware layouts in the agents as the allocation order config:

allocation-order = ["cuda", "rocm", "tpu", "cpu", "mem"]

We also need to add a new, similar shared config option to separately set the resource slot precedence for the UI displays.

@achimnol achimnol added type:feature Add new features comp:manager Related to Manager component effort:normal Need to understand a few modules / some extent of contextual or historical information. urgency:3 Must be finished within a certain time frame. labels Oct 19, 2023
@achimnol achimnol added this to the 24.03 milestone Oct 19, 2023
@achimnol achimnol removed the type:feature Add new features label Oct 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
comp:manager Related to Manager component effort:normal Need to understand a few modules / some extent of contextual or historical information. urgency:3 Must be finished within a certain time frame.
Projects
None yet
Development

No branches or pull requests

1 participant