From 8ab8155dbe579b6851d9b96764cc043c8be1e2c4 Mon Sep 17 00:00:00 2001
From: octodog <mu001@lablup.com>
Date: Fri, 6 Dec 2024 21:58:54 +0900
Subject: [PATCH] fix: Add missing `extra` field to `ContainerRegistryNode` GQL
 query, mutations (#3208) (#3220)

Co-authored-by: Gyubong Lee <jopemachine@naver.com>
---
 changes/3208.fix.md                                 | 1 +
 src/ai/backend/manager/api/schema.graphql           | 9 +++++++++
 src/ai/backend/manager/models/container_registry.py | 8 ++++++++
 3 files changed, 18 insertions(+)
 create mode 100644 changes/3208.fix.md

diff --git a/changes/3208.fix.md b/changes/3208.fix.md
new file mode 100644
index 0000000000..a77aaebeea
--- /dev/null
+++ b/changes/3208.fix.md
@@ -0,0 +1 @@
+Add missing `extra` field to `ContainerRegistryNode` GQL query, mutations.
diff --git a/src/ai/backend/manager/api/schema.graphql b/src/ai/backend/manager/api/schema.graphql
index 1ef2b25498..fd82cb1a12 100644
--- a/src/ai/backend/manager/api/schema.graphql
+++ b/src/ai/backend/manager/api/schema.graphql
@@ -1296,6 +1296,9 @@ type ContainerRegistryNode implements Node {
 
   """Added in 24.09.0."""
   ssl_verify: Boolean
+
+  """Added in 24.09.3."""
+  extra: JSONString
 }
 
 """Added in 24.09.0."""
@@ -1507,6 +1510,9 @@ type Mutations {
 
   """Added in 24.09.0."""
   create_container_registry_node(
+    """Added in 24.09.3."""
+    extra: JSONString
+
     """Added in 24.09.0."""
     is_global: Boolean
 
@@ -1536,6 +1542,9 @@ type Mutations {
 
   """Added in 24.09.0."""
   modify_container_registry_node(
+    """Added in 24.09.3."""
+    extra: JSONString
+
     """Object id. Can be either global id or object id. Added in 24.09.0."""
     id: String!
 
diff --git a/src/ai/backend/manager/models/container_registry.py b/src/ai/backend/manager/models/container_registry.py
index 292f3a455b..17be7c4d20 100644
--- a/src/ai/backend/manager/models/container_registry.py
+++ b/src/ai/backend/manager/models/container_registry.py
@@ -275,6 +275,7 @@ class Meta:
     username = graphene.String(description="Added in 24.09.0.")
     password = graphene.String(description="Added in 24.09.0.")
     ssl_verify = graphene.Boolean(description="Added in 24.09.0.")
+    extra = graphene.JSONString(description="Added in 24.09.3.")
 
     _queryfilter_fieldspec: dict[str, FieldSpecItem] = {
         "row_id": ("id", None),
@@ -357,6 +358,7 @@ def from_row(cls, ctx: GraphQueryContext, row: ContainerRegistryRow) -> Containe
             password=PASSWORD_PLACEHOLDER if row.password is not None else None,
             ssl_verify=row.ssl_verify,
             is_global=row.is_global,
+            extra=row.extra,
         )
 
 
@@ -387,6 +389,7 @@ class Arguments:
         username = graphene.String(description="Added in 24.09.0.")
         password = graphene.String(description="Added in 24.09.0.")
         ssl_verify = graphene.Boolean(description="Added in 24.09.0.")
+        extra = graphene.JSONString(description="Added in 24.09.3.")
 
     @classmethod
     async def mutate(
@@ -401,6 +404,7 @@ async def mutate(
         username: str | UndefinedType = Undefined,
         password: str | UndefinedType = Undefined,
         ssl_verify: bool | UndefinedType = Undefined,
+        extra: dict | UndefinedType = Undefined,
     ) -> CreateContainerRegistryNode:
         ctx: GraphQueryContext = info.context
 
@@ -419,6 +423,7 @@ def _set_if_set(name: str, val: Any) -> None:
         _set_if_set("password", password)
         _set_if_set("ssl_verify", ssl_verify)
         _set_if_set("is_global", is_global)
+        _set_if_set("extra", extra)
 
         async with ctx.db.begin_session() as db_session:
             reg_row = ContainerRegistryRow(**input_config)
@@ -453,6 +458,7 @@ class Arguments:
         username = graphene.String(description="Added in 24.09.0.")
         password = graphene.String(description="Added in 24.09.0.")
         ssl_verify = graphene.Boolean(description="Added in 24.09.0.")
+        extra = graphene.JSONString(description="Added in 24.09.3.")
 
     @classmethod
     async def mutate(
@@ -468,6 +474,7 @@ async def mutate(
         username: str | UndefinedType = Undefined,
         password: str | UndefinedType = Undefined,
         ssl_verify: bool | UndefinedType = Undefined,
+        extra: dict | UndefinedType = Undefined,
     ) -> ModifyContainerRegistryNode:
         ctx: GraphQueryContext = info.context
 
@@ -485,6 +492,7 @@ def _set_if_set(name: str, val: Any) -> None:
         _set_if_set("project", project)
         _set_if_set("ssl_verify", ssl_verify)
         _set_if_set("is_global", is_global)
+        _set_if_set("extra", extra)
 
         _, _id = AsyncNode.resolve_global_id(info, id)
         reg_id = uuid.UUID(_id) if _id else uuid.UUID(id)