Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Core] The episode/experiment "done" flag is not set #7

Open
devrz45 opened this issue May 28, 2023 · 2 comments
Open

[Core] The episode/experiment "done" flag is not set #7

devrz45 opened this issue May 28, 2023 · 2 comments
Assignees
@devrz45
Labels
enhancement New feature or request

Comments

@devrz45
Copy link
Collaborator

devrz45 commented May 28, 2023

When an agent reaches an opponent base, the episode should conclude and "done" parameter should be set to true
@devrz45 devrz45 added the bug Something isn't working label May 28, 2023
@devrz45
Copy link
Collaborator Author

devrz45 commented May 28, 2023

pyreason-gym/tests/base_done_check/test.py

Line 22 in fb54032

print(obs)

@dyumanaditya
Copy link
Contributor

@devrz45 This can be done by modifying the is_done() function here

Use the self.base_positions variable as well as the observations for the agent's position to find the done signal

@dyumanaditya dyumanaditya removed their assignment May 30, 2023
@devrz45 devrz45 added enhancement New feature or request and removed bug Something isn't working labels Jul 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@devrz45 devrz45

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@dyumanaditya @devrz45