Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Error handling B2F message with leading CRLFs #86

Closed
martinhpedersen opened this issue Oct 18, 2023 · 0 comments
Closed

Error handling B2F message with leading CRLFs #86

martinhpedersen opened this issue Oct 18, 2023 · 0 comments
Assignees
Labels

Comments

@martinhpedersen
Copy link
Member

While testing an unrelated PR I encountered a bug that caused a received message to get lost "in transit" to disk without reporting the failure as an error to the remote station. This resulted in message loss.

So I did some more digging, and found a case where we would end up writing an empty .b2f file that could explain the bug I observed.

If the B2F message we receive is a headerless message (or a message starting with the header delimiter CRLFx2), we end up not reporting any error and just writing an empty message to disk. The empty file written to disk as a result will produce the error I observed when testing this PR. Unfortunately, since the buggy message was lost I can't confirm my theory.

Originally posted by @martinhpedersen in la5nta/pat#426 (comment)

@martinhpedersen martinhpedersen self-assigned this Oct 18, 2023
martinhpedersen added a commit that referenced this issue Oct 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant