Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changing the polling interval is not persistent #62

Open
italovalcy opened this issue Mar 9, 2021 · 2 comments
Open

Changing the polling interval is not persistent #62

italovalcy opened this issue Mar 9, 2021 · 2 comments
Labels

Comments

@italovalcy
Copy link

Hi guys,

If you change the polling interval and restart kytos, the change is lost.

Steps to reproduce:

  1. Chante the polling interval on of_lldp:
$curl -X POST -d '{"polling_time": 1}' -H 'Content-type: application/json'  http://localhost:8181/api/kytos/of_lldp/v1/polling_time
  1. Check if the polling interval was changed:
$ curl -s  http://localhost:8181/api/kytos/of_lldp/v1/polling_time
{"polling_time":1}
  1. Restart kytos:
pkill kytosd
kytosd
  1. Check the polling interval again
$ curl -s  http://localhost:8181/api/kytos/of_lldp/v1/polling_time

Expected behavior: the polling interval should be the same previously configured through the API.

Actual behavior: the polling interval falls back to the default value

@cmagnobarbosa
Copy link
Member

Today, this modification is not persistent by design, the default value for polling_time can be changed in setting.py file. But I think we can discuss whether that behavior needs to be changed.

@italovalcy
Copy link
Author

Hi Carlos, Thank you for the feedback!! If that is by design, no problem you can go ahead and close the issue. However, in my opinion, either the API to change this value should be better documented to make it explicit that it will not be saved or it should be persistent.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants