Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

API call /maintenance on POST is returning misleading response status #43

Open
ArturoQuintana opened this issue May 14, 2021 · 0 comments
Assignees

Comments

@ArturoQuintana
Copy link

ArturoQuintana commented May 14, 2021

  • If the payload items field is empty, it is returning 201 when it should be 400.

Example:
# Sets up a wrong maintenance window data
payload = {
"description": "my MW on switch 2",
"start": start.strftime(TIME_FMT),
"end": end.strftime(TIME_FMT),
"items": []
}
reflected on end-to-end test: tests/test_e2e_15_maintenance.py::TestE2EMaintenance::test_024_create_mw_on_switch_should_fail_items_empty

In the case where the payload does not have an items field, it is returning 500 when should be 400.
Example:
# Sets up a wrong maintenance window data
payload = {
"description": "my MW on switch 2",
"start": start.strftime(TIME_FMT),
"end": end.strftime(TIME_FMT)
}
reflected on end-to-end test:
tests/test_e2e_15_maintenance.py::TestE2EMaintenance::test_026_create_mw_on_switch_should_fail_no_items_field_on_payload

  • A not serializable JSON broke the application, and it should return a 415 error.

Example:
# Sets up a wrong maintenance window data
payload = {"a"}
reflected on end-to-end test:
tests/test_e2e_15_maintenance.py::TestE2EMaintenance::test_029_create_mw_on_switch_should_fail_wrong_payload

@ajoaoff ajoaoff self-assigned this May 14, 2021
ajoaoff added a commit to ajoaoff/maintenance that referenced this issue Jun 8, 2021
Use werkzeug exception classes to return the correct error
codes.
Also raise a ValueError if no item is provided on creation
Fixes kytos#43
ajoaoff added a commit to ajoaoff/maintenance that referenced this issue Jun 8, 2021
Use werkzeug exception classes to return the correct error
codes.
Also raise a ValueError if no item is provided on creation
Fixes kytos#43
ajoaoff added a commit to ajoaoff/maintenance that referenced this issue Jun 11, 2021
Use werkzeug exception classes to return the correct error
codes.
Also raise a ValueError if no item is provided on creation
Fixes kytos#43
ajoaoff referenced this issue in kytos-ng/maintenance Jun 18, 2021
* Use werkzeug Exception classes

Use werkzeug exception classes to return the correct error
codes.
Also raise a ValueError if no item is provided on creation
Fixes #43

* Fix return codes

Fix some return codes on update, delete and end maintenance.
Fix #44

* Upgrade versions and fix linter issues

* Fixed test error

* Do not allow items with empty list on update
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants