Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AreaSettings.bin flags not being saved in PLA #357

Open
drvictorvs opened this issue Jan 30, 2024 · 1 comment
Open

AreaSettings.bin flags not being saved in PLA #357

drvictorvs opened this issue Jan 30, 2024 · 1 comment
Labels
bug Something isn't working good first issue Good for newcomers help wanted Extra attention is needed

Comments

@drvictorvs
Copy link
Contributor

drvictorvs commented Jan 30, 2024

In the Fields editor on PLA, the editor only saves the subtables under AreaSettingsTable, as can be seen below:

pkNX.Structures.FlatBuffers.Arceus\Arceus\Field\Resident\Editing\ResidentArea.cs

public void SaveInfo()
    {
        TryWrite(Settings.Encounters, Encounters);
        TryWrite(Settings.Locations, Locations);
        TryWrite(Settings.Spawners, Spawners);
        TryWrite(Settings.WormholeSpawners, Wormholes);
        TryWrite(Settings.LandmarkItemSpawns, LandItems);
        TryWrite(Settings.LandmarkItems, LandMarks);
        TryWrite(Settings.UnownSpawners, Unown);
        TryWrite(Settings.Mkrg, Mikaruge);
        TryWrite(Settings.SearchItem, SearchItem);
    }

Meaning all the other fields under pkNX.Structures.FlatBuffers.Arceus\Schemas\Field\Resident\AreaSettingsTable.fbs are not being saved.

The method for writing the remaining fields under the AreaSettings class is not implemented for the function Write. Is there some technical limitation for that?

Best regards.

@duckdoom5
Copy link

Not that I know of. I suppose someone just forgot to implement them

@duckdoom4 duckdoom4 added bug Something isn't working help wanted Extra attention is needed good first issue Good for newcomers labels Jan 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working good first issue Good for newcomers help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

3 participants