Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Not all metrics are available. #5428

Open
windowsrefund opened this issue May 13, 2024 · 8 comments
Open

Not all metrics are available. #5428

windowsrefund opened this issue May 13, 2024 · 8 comments
Labels
Bug Created by Linear-GitHub Sync

Comments

@windowsrefund
Copy link

Using Grafana's explorer, I do not see the following metrics:

  • testkube_testtriggers_creations_count
  • testkube_testtriggers_updates_count
  • testkube_testtriggers_deletes_count
  • testkube_testtriggers_bulk_updates_count
  • testkube_testtriggers_bulk_deletes_count

To Reproduce
Steps to reproduce the behavior:

  1. Ensure the testkube-api-server-servicemonitor ServiceMonitor is configured.
  2. Verify other metrics are seen in Grafana Metrics Explorer (testkube_test*).
  3. Attempt to query for metrics starting with testkube_testtr

Expected behavior

All metrics mentioned in the documentation (linked above) are published.

Version / Cluster

  • Testkube 1.17.21
@windowsrefund windowsrefund added the bug 🐛 Something is not working as should be label May 13, 2024
@vsukhin
Copy link
Collaborator

vsukhin commented May 13, 2024

thank you @windowsrefund will check

@vsukhin
Copy link
Collaborator

vsukhin commented May 14, 2024

so, these metrics are used when you create/update/dellete test triggers using api, did you call it?

@windowsrefund
Copy link
Author

windowsrefund commented May 14, 2024

I've created triggers via kubectl apply ... Are you saying these metrics are only published if the triggers are created using the testkube binary or dashboard?

@vsukhin
Copy link
Collaborator

vsukhin commented May 14, 2024

think so, @dejanzele ?

@windowsrefund
Copy link
Author

If so, that's quite the limited use case as I'd tend to think larger shops aren't going to be working in that capacity to create and deploy their triggers. Instead, you're going to fold those bits into a Helm deployment (or something) when you're deploying across more than a few clusters.

@vsukhin
Copy link
Collaborator

vsukhin commented May 14, 2024

agrree, need to change

@vsukhin
Copy link
Collaborator

vsukhin commented May 16, 2024

hey, @windowsrefund I rechecked the code and it sound like a more global thing. We do collect information when test or testsuite crd is created in the cluster and send it for telemtry purposes, if it's enabled. But prometheus metrics are linked to the particular testkube api server instance and reflect activity in this instance and you can have multiple testkube api serverr instances in general. So if crd is created somewhere in Argo flows, we can't simply increase promethues metrics for the first available tekube api server instance

might be, we need to send them not only to telemetry server, but to the metrcis server as well

@vsukhin
Copy link
Collaborator

vsukhin commented May 16, 2024

might be we can add such metrics to operator, because itt's responsible for recomcilliation of all Testkueb CRD

@linear linear bot added Bug Created by Linear-GitHub Sync and removed bug 🐛 Something is not working as should be labels Jul 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Created by Linear-GitHub Sync
Projects
None yet
Development

No branches or pull requests

2 participants