Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement test detection for ginkgo tests #4927

Open
lsoica opened this issue Jan 23, 2024 · 1 comment
Open

Implement test detection for ginkgo tests #4927

lsoica opened this issue Jan 23, 2024 · 1 comment

Comments

@lsoica
Copy link

lsoica commented Jan 23, 2024

Currently, executing testkube generate tests-crds . returns

# getting test options for file user_authentication_test.go can't detect executor type by passed file content (), please pass valid --type flag
---

As the IsWithPath function for the ginkgo detector is not implemented:
https://github.com/kubeshop/testkube/blob/main/contrib/executor/ginkgo/pkg/ginkgo/ginkgo.go#L31

// IsWithPath detects based on upsert test options what kind of test it is
func (d Detector) IsWithPath(path string, options apiClient.UpsertTestOptions) (name string, ok bool) {
	// TODO: implement for multiple files test
	return "", false
}
@vsukhin
Copy link
Collaborator

vsukhin commented Jan 23, 2024

hey @lsoica Thank you for a good question. At the moment we don't support crd generation for a folder based tests like Ginkgo, it only works for a single file based tests. But we are going to improve it in Pro edition, ping @TheBrunoLopes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants