Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stable releases? #843

Closed
henrik-farre opened this issue May 17, 2024 · 15 comments
Closed

Stable releases? #843

henrik-farre opened this issue May 17, 2024 · 15 comments

Comments

@henrik-farre
Copy link

Describe the enhancement you'd like to see
Current I'm trying to upgrade to a newer version of the helm chart, but I keep running into issues. Some of the versions can't install because of CRD issues, other times it is the testkube application that givens an error.

When I look at the releases for the helm chart I do not see any release notes that indicate I have to change anything or do something special to upgrade.

Currently I'm at helm chart 1.7.15 and have tried versions up until 1.7.48 (also clean installs).

Are all these versions development or pre-releases?

I would very much like to see stable releases with changelogs ❤️

@devantler
Copy link

I am in the same boat as Henrik.

This is our latest working release:

apiVersion: helm.toolkit.fluxcd.io/v2
kind: HelmRelease
metadata:
  name: testkube
spec:
  interval: 5m
  install:
    crds: CreateReplace
  upgrade:
    crds: CreateReplace
  chart:
    spec:
      chart: testkube
      version: 1.17.20
      sourceRef:
        kind: HelmRepository
        name: testkube
  # https://github.com/kubeshop/helm-charts/blob/develop/charts/testkube/values.yaml
  values:
    global:
      imageRegistry: ${testkube_image_registry:=docker.io}

@vsukhin
Copy link
Contributor

vsukhin commented May 17, 2024

hey, guys! Sorry, we had a testkube application bug in a few latest releases we didn't note, around 1.17.25, it was fixed in 1.17.33

regarding CRD issues, do I understand right, that this is related to test workflow template resource creation? It should be done in Helm post hook @tkonieczny

@henrik-farre
Copy link
Author

Let me just spin up a cluster and give you the precise error, ~30min.

@vsukhin
Copy link
Contributor

vsukhin commented May 17, 2024

thank you!

@henrik-farre
Copy link
Author

henrik-farre commented May 17, 2024

> helm pull kubeshop/testkube --version 1.17.48
> # unpack chart
> helm install testkube .
coalesce.go:286: warning: cannot overwrite table with non table for testkube.testkube-api.minio.extraEnvVars (map[])
coalesce.go:286: warning: cannot overwrite table with non table for testkube.testkube-api.minio.extraEnvVars (map[])
coalesce.go:286: warning: cannot overwrite table with non table for testkube.testkube-api.minio.extraEnvVars (map[])
Error: INSTALLATION FAILED: unable to build kubernetes objects from release manifest: resource mapping not found for name: "distribute--evenly" namespace: "" from "": no matches for kind "TestWorkflowTemplate" in version "testworkflows.testkube.io/v1"
ensure CRDs are installed first
zsh: exit 1     helm install testkube .

This is on a clean minikube cluster

Same result on a cloud provided cluster

@vsukhin
Copy link
Contributor

vsukhin commented May 17, 2024

I see, this is what I thought about. Let us check it outt

@vsukhin
Copy link
Contributor

vsukhin commented May 17, 2024

@vsukhin
Copy link
Contributor

vsukhin commented May 17, 2024

@henrik-farre released a fix for help. can you try it now?

@henrik-farre
Copy link
Author

Give me ~10min

@henrik-farre
Copy link
Author

> helm install testkube .
coalesce.go:286: warning: cannot overwrite table with non table for testkube.testkube-api.minio.extraEnvVars (map[])
coalesce.go:286: warning: cannot overwrite table with non table for testkube.testkube-api.minio.extraEnvVars (map[])
coalesce.go:286: warning: cannot overwrite table with non table for testkube.testkube-api.minio.extraEnvVars (map[])
W0517 14:24:48.050983   48925 warnings.go:70] spec.template.spec.containers[1].ports[0]: duplicate port definition with spec.template.spec.containers[0].ports[0]
NAME: testkube
LAST DEPLOYED: Fri May 17 14:24:23 2024
NAMESPACE: default
STATUS: deployed
REVISION: 1
TEST SUITE: None
NOTES:
Enjoy testing with Testkube!

Works better in minikube, testing in cloud

@henrik-farre
Copy link
Author

We are still investigating problems in cloud cluster, I will update this issue next week when I had time to debug

@vsukhin
Copy link
Contributor

vsukhin commented May 17, 2024

sure, ping us when you have more info. thank you!

@vsukhin
Copy link
Contributor

vsukhin commented May 22, 2024

should be fixed

@vsukhin vsukhin closed this as completed May 22, 2024
@henrik-farre
Copy link
Author

We also use GitOps (not ArgoCD) and it looks like our problem is CRDs not being created. It also looks like other people have reported this #711 kubeshop/testkube#5280 #627

Keep this closed, I will create a new issue if needed.

@vsukhin
Copy link
Contributor

vsukhin commented May 22, 2024

yes, please, open a separated issue with errors from ArgoCD @henrik-farre

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants