Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid reloading Botkube when notification preferences change via remote config #1012

Open
pkosiec opened this issue Mar 8, 2023 · 0 comments
Labels
enhancement New feature or request needs-triage Relates to issues that should be refined

Comments

@pkosiec
Copy link
Member

pkosiec commented Mar 8, 2023

Overview

Currently, we restart Botkube for edit sourcebindings, enable/disable actions, but we don't for the enable/disable notifications command in the ConfigMap-based config. But, in order to achieve the same for remote configuration, we would need to change internal logic so that we:

  • update notifications for a given channel (this needs a single state with all notifier references)
  • get the diff and extract the channel which changed notifications
  • send message to a given channel (channel-based routing map is needed + this needs a rework for the notifier executor)
    • updating notifications should happen after ConfigMap update, not before
    • same for remote config reloader

Reason

Improve UX

See also

Remote config reloader PR: #1006

@pkosiec pkosiec added enhancement New feature or request needs-triage Relates to issues that should be refined labels Mar 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request needs-triage Relates to issues that should be refined
Projects
Status: No status
Development

No branches or pull requests

1 participant