Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: replace golang/mock to uber-go/mock #390

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

chore: replace golang/mock to uber-go/mock #390

wants to merge 4 commits into from
+479 −275

Conversation

chansuke
Copy link
Member

@chansuke chansuke commented Nov 11, 2024 •
edited
Loading

What type of PR is this?

What this PR does / why we need it:

Which issue(s) this PR fixes:

Fixes #363

Special notes for your reviewer:

/label tide/merge-method-squash

@k8s-ci-robot
Copy link
Contributor

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@k8s-ci-robot k8s-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. tide/merge-method-squash Denotes a PR that should be squashed by tide when it merges. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. sig/scheduling Categorizes an issue or PR as relevant to SIG Scheduling. labels Nov 11, 2024
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: chansuke
Once this PR has been reviewed and has the lgtm label, please assign sanposhiho for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Nov 11, 2024
@k8s-ci-robot k8s-ci-robot added the size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. label Nov 11, 2024
@k8s-ci-robot k8s-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Nov 13, 2024
@chansuke chansuke marked this pull request as ready for review November 13, 2024 15:25
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Nov 13, 2024
@chansuke chansuke marked this pull request as draft November 13, 2024 15:28
@k8s-ci-robot k8s-ci-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Nov 13, 2024
@chansuke chansuke changed the title chore: replace golanc/mock to uber-go/mock chore: replace golang/mock to uber-go/mock Nov 13, 2024
@chansuke chansuke marked this pull request as ready for review November 14, 2024 14:29
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Nov 14, 2024
@196Ikuchil
Copy link
Contributor

/assign

196Ikuchil
196Ikuchil reviewed Nov 17, 2024
View reviewed changes
Copy link
Contributor

@196Ikuchil 196Ikuchil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@chansuke
Thanks!
Please check the review comments!

Also, I think we should update tools/tools.go.

kube-scheduler-simulator/tools/tools.go

Line 8 in b3c7a44

_ "github.com/golang/mock/mockgen"

simulator/go.mod
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did you execute go mod tidy after these changes? 👀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@196Ikuchil 196Ikuchil 196Ikuchil left review comments

Assignees

@196Ikuchil 196Ikuchil

Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. sig/scheduling Categorizes an issue or PR as relevant to SIG Scheduling. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. tide/merge-method-squash Denotes a PR that should be squashed by tide when it merges.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Replace golang/mock with uber-go/mock
3 participants
@chansuke @k8s-ci-robot @196Ikuchil