From 0a7887092c79ec5522fe2dba867c745629c95b88 Mon Sep 17 00:00:00 2001 From: Javier Vela Date: Thu, 5 Dec 2024 13:52:21 +0100 Subject: [PATCH] Added support to setup the containerPort property of the container webhook Signed-off-by: Javier Vela --- charts/external-dns/CHANGELOG.md | 1 + charts/external-dns/README.md | 8 +++++++- charts/external-dns/templates/deployment.yaml | 2 +- charts/external-dns/values.yaml | 3 +++ 4 files changed, 12 insertions(+), 2 deletions(-) diff --git a/charts/external-dns/CHANGELOG.md b/charts/external-dns/CHANGELOG.md index 5743f511b6..9bc04d7cae 100644 --- a/charts/external-dns/CHANGELOG.md +++ b/charts/external-dns/CHANGELOG.md @@ -22,6 +22,7 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0 - Ability to configure `imagePullSecrets` via helm `global` value ([#4667](https://github.com/kubernetes-sigs/external-dns/pull/4667)) _@jkroepke_ - Added options to configure `labelFilter` and `managedRecordTypes` via dedicated helm values ([#4849](https://github.com/kubernetes-sigs/external-dns/pull/4849)) _@abaguas_ +- Added support to setup the `containerPort` property of the container `webhook` ([4934](https://github.com/kubernetes-sigs/external-dns/issues/4934)) _@fjvela_ ### Fixed diff --git a/charts/external-dns/README.md b/charts/external-dns/README.md index 2a7147eb05..d5f231899a 100644 --- a/charts/external-dns/README.md +++ b/charts/external-dns/README.md @@ -1,6 +1,8 @@ # external-dns -![Version: 1.15.0](https://img.shields.io/badge/Version-1.15.0-informational?style=flat-square) ![Type: application](https://img.shields.io/badge/Type-application-informational?style=flat-square) ![AppVersion: 0.15.0](https://img.shields.io/badge/AppVersion-0.15.0-informational?style=flat-square) + + +![Version: 1.15.0](https://img.shields.io/badge/Version-1.15.0-informational?style=flat-square) ![Type: application](https://img.shields.io/badge/Type-application-informational?style=flat-square) ![AppVersion: 0.15.0](https://img.shields.io/badge/AppVersion-0.15.0-informational?style=flat-square) ExternalDNS synchronizes exposed Kubernetes Services and Ingresses with DNS providers. @@ -86,6 +88,9 @@ If `namespaced` is set to `true`, please ensure that `sources` my only contains | `node` | ❌ | | | `pod` | ❌ | | + + + ## Values | Key | Type | Default | Description | @@ -127,6 +132,7 @@ If `namespaced` is set to `true`, please ensure that `sources` my only contains | priorityClassName | string | `nil` | Priority class name for the `Pod`. | | provider.name | string | `"aws"` | _ExternalDNS_ provider name; for the available providers and how to configure them see [README](https://github.com/kubernetes-sigs/external-dns/blob/master/charts/external-dns/README.md#providers). | | provider.webhook.args | list | `[]` | Extra arguments to provide for the `webhook` container. | +| provider.webhook.containerPort | int | `8080` | Container port for the `webhook` container. | | provider.webhook.env | list | `[]` | [Environment variables](https://kubernetes.io/docs/tasks/inject-data-application/define-environment-variable-container/) for the `webhook` container. | | provider.webhook.extraVolumeMounts | list | `[]` | Extra [volume mounts](https://kubernetes.io/docs/concepts/storage/volumes/) for the `webhook` container. | | provider.webhook.image.pullPolicy | string | `"IfNotPresent"` | Image pull policy for the `webhook` container. | diff --git a/charts/external-dns/templates/deployment.yaml b/charts/external-dns/templates/deployment.yaml index 46a41de4fa..e61f980525 100644 --- a/charts/external-dns/templates/deployment.yaml +++ b/charts/external-dns/templates/deployment.yaml @@ -166,7 +166,7 @@ spec: ports: - name: http-webhook protocol: TCP - containerPort: 8080 + containerPort: {{ .containerPort }} livenessProbe: {{- toYaml .livenessProbe | nindent 12 }} readinessProbe: diff --git a/charts/external-dns/values.yaml b/charts/external-dns/values.yaml index 0a6ee4849b..f27e155c2d 100644 --- a/charts/external-dns/values.yaml +++ b/charts/external-dns/values.yaml @@ -239,6 +239,9 @@ provider: # -- _ExternalDNS_ provider name; for the available providers and how to configure them see [README](https://github.com/kubernetes-sigs/external-dns/blob/master/charts/external-dns/README.md#providers). name: aws webhook: + # -- Container port for the `webhook` container. + containerPort: 8080 + image: # -- (string) Image repository for the `webhook` container. repository: