🐛 fix: create lbaas in specified subnet #2339
Conversation
k8s-ci-robot
added
cncf-cla: yes
|
Hi @simonostendorf. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
✅ Deploy Preview for kubernetes-sigs-cluster-api-openstack ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
|
/ok-to-test |
k8s-ci-robot
added
ok-to-test
| @@ -640,6 +644,8 @@ func resolveLoadBalancerNetwork(openStackCluster *infrav1.OpenStackCluster, netw | |||
| return fmt.Errorf("no subnet match was found in the specified network (specified subnet: %v, available subnets: %v)", s, lbNet.Subnets) | |||
| } | |||
| } | |||
|
|
|||
| openStackCluster.Status.APIServerLoadBalancer.LoadBalancerNetwork = lbNetStatus | |||
There was a problem hiding this comment.
Looks like a genuine bug. I guess the reason we didn't notice is because we do not test this in e2e. We just enable the loadbalancer and use the defaults.
k8s-ci-robot
added
the
lgtm
| @@ -640,6 +644,8 @@ func resolveLoadBalancerNetwork(openStackCluster *infrav1.OpenStackCluster, netw | |||
| return fmt.Errorf("no subnet match was found in the specified network (specified subnet: %v, available subnets: %v)", s, lbNet.Subnets) | |||
| } | |||
| } | |||
|
|
|||
| openStackCluster.Status.APIServerLoadBalancer.LoadBalancerNetwork = lbNetStatus | |||
There was a problem hiding this comment.
Looks like a genuine bug. I guess the reason we didn't notice is because we do not test this in e2e. We just enable the loadbalancer and use the defaults.
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: lentzi90 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
|
/cherry-pick release-0.11 |
|
@lentzi90: new pull request created: #2363 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
/cherry-pick release-0.10 |
|
@lentzi90: new pull request created: #2364 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
What this PR does / why we need it:
The load balancer should be created in the specified lb network if it is defined and it exists. This does not work, see issue #2149.
This PR tries to fix this by writing the read info for the lb network to the status.
I did lots of debugging and found out that the network and subnet info is read in every reconcile loop, written to the local variables but is not saved in the openStackCluster.Status.apiServerLoadBalancer.loadBalancerNetwork field. I tried to fix this by adding the needed line(s).
I also added some more info for the lb subnet to the status to look equal to the normal cluster subnet status.
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close the issue(s) when PR gets merged):fixes #2149
Special notes for your reviewer:
TODOs: