Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add streaming list support to WatchParams #1254

Closed
clux opened this issue Jul 15, 2023 · 0 comments · Fixed by #1255
Closed

Add streaming list support to WatchParams #1254

clux opened this issue Jul 15, 2023 · 0 comments · Fixed by #1255
Labels
blocked awaiting upstream work core generic apimachinery style work help wanted Not immediately prioritised, please help!

Comments

@clux
Copy link
Member

clux commented Jul 15, 2023

What problem are you trying to solve?

Supporting streaming lists on kubernetes > 1.27 https://kubernetes.io/docs/reference/using-api/api-concepts/#streaming-lists

Describe the solution you'd like

The initial support of this does not need to touch the watcher (#1209 has higher level discussion) nor Api::watch. Adding the flag to WatchParams is sufficient to support it:

  • Wait for a k8s-openapi release with 1_27 support (reason for blocked)
  • Add send_initial_events: bool to WatchParams in params.rs in kube-core
  • Hide it behind a k8s_openapi::k8s_if_ge_1_27 macro
  • Add a WatchParams::initial_events() builder that allows turning it on easily
  • Test that it gets added to query strings in requests.rs in kube-core (also gated by 1_27 macro)
  • Make an example use it. maybe event_watcher.rs

Describe alternatives you've considered

None, new feature, should be supported.

Documentation, Adoption, Migration Strategy

Straight addition. Just make sure we hide it and tests under the k8s_openapi 1_27 feature. Integration tests are already using >=1.27 so we are just waiting for a k8s-openapi release to give us the standard macro.

Target crate for feature

kube-core

@clux clux added help wanted Not immediately prioritised, please help! blocked awaiting upstream work core generic apimachinery style work labels Jul 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
blocked awaiting upstream work core generic apimachinery style work help wanted Not immediately prioritised, please help!
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant