Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Batch export operations #21

Open
krupkat opened this issue Aug 15, 2022 · 2 comments
Open

Batch export operations #21

krupkat opened this issue Aug 15, 2022 · 2 comments
Assignees
Labels
enhancement New feature or request

Comments

@krupkat
Copy link
Owner

krupkat commented Aug 15, 2022

Base: Implement "Export all" action
Stretch goal: Implement "Export selected" action

Starting point:
Code location

@krupkat krupkat added the enhancement New feature or request label Aug 15, 2022
@krupkat
Copy link
Owner Author

krupkat commented Sep 22, 2022

Some more though needs to go into how panorama state is being handled.

Currently the crop / autofill results are being kept in memory only for the selected panorama. This is because the full resolution panoramas can quickly go into GBs of memory, so it isn't feasible to keep all of them.

We could save only the crop / autofill options per each panorama for lower memory requirements, however the stitch algorithm isn't deterministic, so the result could be quite surprising (especially for crop).

This should be solved by saving the camera parameters after the first successful stitch and then reapplying them in the export/stitch code (setTransform).

@krupkat krupkat self-assigned this Sep 23, 2022
@krupkat
Copy link
Owner Author

krupkat commented Apr 8, 2023

Test of the feature: https://github.com/krupkat/xpano/tree/feature-batch

The approach of saving + restoring camera parameters works well, implementing this will mean that Xpano won't need to recompute the camera parameters when switching between panos.

Eventually export + import of the camera parameters can be implemented.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant